[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v5]
From:       Coleen Phillimore <coleenp () openjdk ! org>
Date:       2024-01-29 17:10:42
Message-ID: nG_zjtFu6UUgJ4xUOdf5O53odsLpn9a1UCfJsbT-iVQ=.9aaaa73f-b908-4bfa-88bb-d8288ea1e722 () github ! com
[Download RAW message or body]

On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:

> > This mechanically replaces NULL with nullptr in hpp/cpp native files in test \
> > native code.  This didn't attempt to change NULL in comments to say null because \
> > nullptr is generally the right thing for the comment to say.  It does attempt to \
> > change NULL to "null" rather than "nullptr" in strings.  Any changes for \
> > "nullptr" to "null" in comments can be changed in a future RFE in a smaller \
> > patch. I didn't see any when it was scrolling by to make my script more \
> > complicated. 
> > Ran tier1-4 testing.
> 
> Coleen Phillimore has updated the pull request incrementally with two additional \
> commits since the last revision: 
> - Fix some casts unnecessary with nullptr
> - Fix copyrights

macos-aarch64 build failure in GHA appears unrelated, internal testing passed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17593#issuecomment-1915186403


[prev in list] [next in list] [prev in thread] [next in thread]