[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8324637: [aix] Implement support for reporting swap space in jdk.management
From:       Kevin Walls <kevinw () openjdk ! org>
Date:       2024-01-25 16:46:37
Message-ID: OjltmvkjGR_pFE9EuwKIvi4caQipiGVaMOh_Xr2U4mg=.bb55983e-97f0-46f5-a633-8bebb59885a4 () github ! com
[Download RAW message or body]

On Thu, 25 Jan 2024 15:33:36 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> > I can't try this and don't use AIX, but it looks good. It follows the same \
> > pattern as the other AIX cases in the file. Although the others (e.g. line 200) \
> > don't throw_internal_error if the call returns -1, they just return -1. You might \
> > want to do that for consistency of behaviour.
> 
> Hi I wanted to be consistent to the other OS in \
> get_total_or_available_swap_space_size, that#s why the throw_internal_error .

Ok yes, you can choose who to be consistent with... 8-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17569#issuecomment-1910585693


[prev in list] [next in list] [prev in thread] [next in thread]