[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8322237: Heap dump contains duplicate thread records for mounted virtual threads [v4]
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2023-12-24 11:06:51
Message-ID: n83sQEpgJWTW3g5RTD4AFoQ8o3MmzAlbRzqMYK_yyu0=.edece2a6-2e5e-4617-9d7b-44b665f24a1a () github ! com
[Download RAW message or body]

On Fri, 22 Dec 2023 20:52:48 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> > HeapDumper dumps virtual threads in 2 places:
> > - dumping platform threads (mounted virtual threads are dumped as separate thread \
> >                 object);
> > - dumping heap objects when the object is `java.lang.VirtualThread`.
> > 
> > In the 2nd case mounted virtual threads should be skipped (as they are already \
> > dumped with correct stack traces/stack references) Check that a virtual thread is \
> > mounted is non-trivial, method from JvmtiEnvBase was used for this. 
> > Testing: tier1..3, heapdump-related tests: \
> > open/test/hotspot/jtreg/serviceability,open/test/hotspot/jtreg/runtime/ErrorHandling,open/test/hotspot/jtreg/gc/epsilon,open/test/jdk/sun/tools/jhsdb
> > 
> 
> Alex Menkov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> feedback: extended comment

Thank you for the update!

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17134#pullrequestreview-1795555865


[prev in list] [next in list] [prev in thread] [next in thread]