[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow [v2]
From:       Jaikiran Pai <jpai () openjdk ! org>
Date:       2023-12-20 12:21:44
Message-ID: pWQTrp6K0oZirMeCkw5FOkO5bZYqjtzFTux0D1aCT3I=.af6edf23-bfef-48aa-8d10-5291b64dfbaa () github ! com
[Download RAW message or body]

On Tue, 19 Dec 2023 20:13:58 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> > Jaikiran Pai has updated the pull request incrementally with two additional \
> > commits since the last revision: 
> > - David's review comments - reduce if blocks and release the array outside if \
> >                 block
> > - David's review comment - punctuation
> 
> src/hotspot/os/posix/perfMemory_posix.cpp line 609:
> 
> > 607:     if (statbuf.st_size > 0 && statbuf.st_ctime > oldest_ctime) {
> > 608: 
> > 609:       if (statbuf.st_ctime > oldest_ctime) {
> 
> This `if` expression repeats what we already know to be true from the previous `if` \
> expression.

Hello Chris, you are right - this additional `if` isn't needed. It looks like this is \
only there in `_posix` file and not in the `windows` version (which also \
intentionally doesn't have the file size check). I've updated this PR to fix this \
`_posix` one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17104#discussion_r1432643800


[prev in list] [next in list] [prev in thread] [next in thread]