[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8321404: Limit the number of heap dumps triggered by HeapDumpBeforeFullGC/AfterFullGC [v3]
From:       Chris Plummer <cjplummer () openjdk ! org>
Date:       2023-12-18 17:49:39
Message-ID: sRKdpQTF3U68her0-saty73nrp__pcmA_BToCUvVJJc=.73229e56-3d76-4044-8b4d-06023e57876d () github ! com
[Download RAW message or body]

On Sat, 16 Dec 2023 04:36:57 GMT, Denghui Dong <ddong@openjdk.org> wrote:

> > Hi,
> > 
> > Could I have a review of this patch?
> > 
> > In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will generate \
> > dumps for every FGC, increasing the risk of disk full. 
> > This patch introduces a new option 'FullGCHeapDumpLimit' to limit the number of \
> > dumps triggered by HeapDumpBeforeFullGC/AfterFullGC to enhance \
> > production-friendliness. 
> > Best,
> > Denghui
> 
> Denghui Dong has updated the pull request incrementally with one additional commit \
> since the last revision: 
> refine description

Marked as reviewed by cjplummer (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/16976#pullrequestreview-1787426650


[prev in list] [next in list] [prev in thread] [next in thread]