[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8322062: com/sun/jdi/JdwpAllowTest.java does not performs negative testing with prefix 
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2023-12-16 7:29:36
Message-ID: mFDlwAzdpJhFlvnW6rekrS1KrqTbmkRLKLmFX5Xnrcc=.66e3e960-e03d-41b5-b222-b599c0ea6a32 () github ! com
[Download RAW message or body]

On Fri, 15 Dec 2023 19:43:36 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> The fix updated JdwpAllowTest to test negative scenarios (debugger tries to attach \
> from not allowed address). 
> MaskTest ctor incorrectly calculates prefix length for negative tests and test \
> main() calls `positiveTest` instead of `negativeTest` for `prefixLengthBad`. 
> Also fixes test output:
> LingeredApp logs to System.out and the test logs to System.err, this makes harder \
> log analysis.

Looks good. Nice comment about `bitToChange` values.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17131#pullrequestreview-1785143379


[prev in list] [next in list] [prev in thread] [next in thread]