[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]
From:       Leonid Mesnik <lmesnik () openjdk ! org>
Date:       2023-12-12 22:55:22
Message-ID: EHXy4M1_vmtXK10EOzazRoLWXos1B3EGy4bsYch8G7U=.edd664cb-ed1b-43a1-9d53-8a492c669b52 () github ! com
[Download RAW message or body]

On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson <stefank@openjdk.org> wrote:

> > [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename \
> > createJavaProcessBuilder' changed the name of the ProcessTools helper functions \
> > used to create `ProcessBuilder`s used to spawn new java test processes. 
> > We now have `createTestJavaProcessBuilder` and `createLimitedTestJavaProcess`. \
> > The former prepends jvm options from jtreg, while the latter doesn't. 
> > With these functions it is common to see the following pattern in tests:
> > 
> > ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(...);
> > OutputAnalyzer output = executeProcess(pb);
> > 
> > 
> > We have a couple of thin wrapper in `ProcessTools` that does exactly this, so \
> > that the code can be written as a one-liner: 
> > OutputAnalyzer output = ProcessTools.executeTestJvm();
> > 
> > 
> > I propose that we name this functions using the same naming scheme we used for \
> > `createTestJavaProcessBuilder` and `createLimitedTestJavaProcessBuilder`. That \
> > is, we change `executeTestJvm` to `executeTestJava` and add a new \
> > `executeLimitedTestJava` function.
> 
> Stefan Karlsson has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Test cleanup

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17049#pullrequestreview-1778566038


[prev in list] [next in list] [prev in thread] [next in thread]