[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8320860: add-opens/add-exports require '=' in JAVA_TOOL_OPTIONS
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2023-11-30 23:22:05
Message-ID: EMLZYph5ceJdm1Ery0qCU1C4t4GV3lOomTDGOKsvCck=.76b48ce9-c525-4b8e-996f-08467ff0b87e () github ! com
[Download RAW message or body]

On Thu, 30 Nov 2023 04:30:28 GMT, David Holmes <dholmes@openjdk.org> wrote:

> Please review this simple clarification to the JVM TI spec regarding use of \
> `JAVA_TOOL_OPTIONS` in regards to module options and their format. 
> I do not believe this clarification needs a CSR request.
> 
> Thanks.

The fix looks okay to me modulo Alan's suggestion to consider using the JNI version.

David, thank you for fixing this!

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16896#pullrequestreview-1758654184
PR Comment: https://git.openjdk.org/jdk/pull/16896#issuecomment-1834713309


[prev in list] [next in list] [prev in thread] [next in thread]