[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v5]
From:       David Holmes <dholmes () openjdk ! org>
Date:       2023-11-30 2:45:13
Message-ID: APicyrkmh0o2m6H-2gUIMalL4yl4xYLWjMGd5Wzvfww=.f4126797-b155-4f54-a6cc-df470353d798 () github ! com
[Download RAW message or body]

On Tue, 28 Nov 2023 23:25:27 GMT, Yi-Fan Tsai <duke@openjdk.org> wrote:

> > `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: \
> > `/tmp/perf-%d.map`. This change adds an optional argument for specifying a file \
> > name. 
> > `jcmd PID help Compiler.perfmap` shows the following usage.
> > 
> > 
> > Compiler.perfmap
> > Write map file for Linux perf tool.
> > 
> > Impact: Low
> > 
> > Syntax : Compiler.perfmap  [<filename>]
> > 
> > Arguments:
> > filename : [optional] Name of the map file (STRING, no default value)
> > 
> > 
> > The man page of jcmd will be updated in a separate PR.
> 
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Apply man changes

@yftsai , @plummercj  my aplogies on the CSR situation. Since Sep 22 I have been \
reminded that changing the command-line of our diagnostic tools, is treated as a \
"diagnostic" option per the CSR FAQ and does not require a CSR request.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15871#issuecomment-1833017497


[prev in list] [next in list] [prev in thread] [next in thread]