[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8315966: Relativize initial_sp in interpreter frames [v3]
From:       Fredrik Bredberg <fbredberg () openjdk ! org>
Date:       2023-09-27 12:58:10
Message-ID: 1NStq2k2grGtpP_s7I1zmk8Uj23YO0dXEBhYfe5b6p0=.ad622f98-035c-44f9-9f43-8ac9f38ca436 () github ! com
[Download RAW message or body]

On Wed, 27 Sep 2023 09:07:23 GMT, Fredrik Bredberg <fbredberg@openjdk.org> wrote:

> > Relativize initial_sp in interpreter frames.
> > 
> > By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on PowerPC) \
> > member in interpreter frames from being an absolute address into an offset that \
> > is relative to the frame pointer, we don't need to change the value as we freeze \
> > and thaw frames of virtual threads. This is since we might freeze and thaw from \
> > and to different worker threads, so the absolute address to locals might change, \
> > but the offset from the frame pointer will be constant. 
> > This subtask only handles relativization of "initial_sp" and "monitor_block_top" \
> > since it's the same slot in interpreter frames (roughly the same as "monitors" on \
> > PowerPC). Relativization of other interpreter frame members are handled in other \
> > subtasks to JDK-8289296. 
> > Tested tier1-tier7 on supported platforms. The rest was sanity tested using Qemu.
> 
> Fredrik Bredberg has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Removed whitespace (RISC-V only).

Thank you all. If no one else has anything to add, I'll integrate (as soon as I can \
convince a sponsor).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15815#issuecomment-1737349402


[prev in list] [next in list] [prev in thread] [next in thread]