[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if 
From:       Axel Boldt-Christmas <aboldtch () openjdk ! org>
Date:       2023-09-27 8:19:29
Message-ID: l2ZGG5Kc9RzULlh5we4yStGeeRC-FHuUpEvuG1RJ7qY=.3aaf50c7-8778-43b4-b095-5e506f6269d9 () github ! com
[Download RAW message or body]

On Thu, 21 Sep 2023 06:21:25 GMT, Axel Boldt-Christmas <aboldtch@openjdk.org> wrote:

> > ObjectMonitorIterator fails to return the most resent monitor added. It start \
> > with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor but \
> > fails to ever return the `_head` ObjectMonitor. The current implementation can \
> > also not handle that the `_head` is nullptr (no monitors in the system) and \
> > returns a null ObjectMonitorIterator. Which is interpreted as `monitor list not \
> > supported, too old hotspot VM`. 
> > Changed the iterator to keep return the current monitor (starts with `_head`) and \
> > decoupled `_head == nullptr` from the question if ObjectMonitorIterator is \
> > supported.  
> > Testing:
> > * Passes all `serviceability/sa` tests
> > * Passed tier 1-5
> > * Passed GHA
> 
> Axel Boldt-Christmas has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Update copyright year

Thanks for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15782#issuecomment-1736918541


[prev in list] [next in list] [prev in thread] [next in thread]