[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg
From:       David Holmes <dholmes () openjdk ! org>
Date:       2023-07-26 12:09:53
Message-ID: 9zr9XwIqhRhZCpv721o90w3RSResmNNgFjp0MNEx9gs=.5ed01b40-1457-4eba-abd2-7c507a6fd448 () github ! com
[Download RAW message or body]

On Wed, 26 Jul 2023 07:22:33 GMT, Jaikiran Pai <jpai@openjdk.org> wrote:

> > Can I please get a review of this test-only change which removes usages of the \
> > deprecated (no-op) `-Xdebug` from these tests? I missed these files when \
> > addressing https://bugs.openjdk.org/browse/JDK-8227229. 
> > tier testing with these changes has passed without issues.
> 
> Thank you David for the review.
> 
> > Looks fine but what about
> > 
> > ./runtime/CommandLine/TestNullTerminatedFlags.java
> > 
> > 
> I left this test untouched intentionally. The summary of that test says:
> 
> > Test that the VM don't allow random junk characters at the end of valid command \
> > line flags.
> 
> Given that `-Xdebug` is still an accepted option, I think letting this test to \
> continue running it against this option would be good. Once we completely remove \
> that option, I think we can update this test.

@jaikiran I had a vague recollection that test was mentioned previously but then \
couldn't find that mention. Fine either way.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15016#issuecomment-1651677196


[prev in list] [next in list] [prev in thread] [next in thread]