[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v2]
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2023-05-31 23:45:05
Message-ID: 0lDpDzve_r8Nj8nYHvT0P4QJklVLu2edSNJ0BIJcrhY=.7aeb9fd6-e2cd-4748-bc6c-31a8a48d046b () github ! com
[Download RAW message or body]

On Wed, 31 May 2023 11:07:02 GMT, Alan Bateman <alanb@openjdk.org> wrote:

> Yes, maybe JvmtiAgentList::load_agent, JvmtiAgent::load, or invoke_Agent_OnAttach. \
> As part of the change to emit a warning when agent code is loaded into a running \
> VM, invoke_Agent_OnAttach needs to check if EnableDynamicAgentLoading has been set \
> on the command line, so looking at this VM option in one place would be nice.

I've moved the EnableDynamicAgentLoading check to the invoke_Agent_OnAttach.
It is the same place where a warning is going to be generated as part of the 8307478 \
(JEP enhancement).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14244#issuecomment-1571100330


[prev in list] [next in list] [prev in thread] [next in thread]