[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
From:       Leonid Mesnik <lmesnik () openjdk ! org>
Date:       2023-05-31 3:15:55
Message-ID: p0Wq7J0crWn6HmRCQBXGCtkiH8__lrCUoBwrP0QPI04=.f2c47f82-0124-43d9-aa2b-d2352167ab91 () github ! com
[Download RAW message or body]

On Wed, 31 May 2023 00:27:16 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> The nsk/jdb tests are not passing the test args on to the debuggee. I found a way \
> to pass all of them (see the CR for details), but Windows had trouble with the \
> parsing. It turns out the only args that the debuggee really cares about are \
> -verbose and -waittime, so I settled on just passing these two, and Windows is \
> happy. 
> Note only a handful of tests run with -verbose as the default. However, with this \
> change at least now if you add -verbose when debugging an issue, you will see \
> verbose log output from the debuggee. Previously you would not.

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14236#pullrequestreview-1452140923


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic