[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v
From:       Paul Hohensee <phh () openjdk ! org>
Date:       2023-05-30 15:57:19
Message-ID: GTsiAVHLoVurWnCmasor7rhHN6D3wGvBGrU-oKbzPZw=.3dede8e0-378b-4fee-a31d-942e7c4bd5e8 () github ! com
[Download RAW message or body]

On Tue, 30 May 2023 14:20:12 GMT, Volker Simonis <simonis@openjdk.org> wrote:

> > Fixed using a high water mark.
> 
> A simple fix for guaranteeing monotonicity, would be to add another field (e.g. \
> `max_allocated_bytes`) which keeps the last result returned by \
> `getTotalThreadAllocatedBytes()` and the latter would then return the maximum of \
> the current computation and `max_allocated_bytes`.

That's what I did. :) Thanks for your review!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13814#discussion_r1210491161


[prev in list] [next in list] [prev in thread] [next in thread]