[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8306851: Move Method access flags [v3]
From:       Coleen Phillimore <coleenp () openjdk ! org>
Date:       2023-04-28 20:00:53
Message-ID: 7o09JnIhYwcYOJhT1zl2necGdXP4bW4rZLmsujrIdmA=.8361d936-5061-43b2-8678-687ef1a94b74 () github ! com
[Download RAW message or body]

On Fri, 28 Apr 2023 18:39:21 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:

> > src/hotspot/share/oops/constMethod.cpp line 438:
> > 
> > > 436:   }
> > > 437:   st->cr();
> > > 438:   st->print(" - flags:             "); _flags.print_on(st);               \
> > > st->cr();
> > 
> > Method prints its flags as an int and in decoded form, but ConstMethod only \
> > prints the decoded form. Any particular reason for this difference?
> 
> No reason for this difference.  The only reason I added the int form for \
> MethodFlags was because AccessFlags were printed also with the int form.

I fixed the constMethod printing with the last commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13654#discussion_r1180757104


[prev in list] [next in list] [prev in thread] [next in thread]