[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8233725: ProcessTools.startProcess() has output issues when using an OutputAnalyzer at the 
From:       Leonid Mesnik <lmesnik () openjdk ! org>
Date:       2023-04-26 14:40:24
Message-ID: gdzL__eUW9ETKVgPy8j-Bd-lsAWqWy5c5I3dbMJuFVc=.4d86bf33-7a04-411c-bdd1-55386fc71c09 () github ! com
[Download RAW message or body]

On Wed, 26 Apr 2023 09:38:45 GMT, Serguei Spitsyn <sspitsyn@openjdk.org> wrote:

> > Right. From the API caller's POV, it is asking for InputStreams that it can use \
> > to read the process' stdout or stderr streams.
> 
> Okay, thanks.
> I'm thinking about simple/short comments on this to make it clear this naming \
> mismatch is intentional.

There is a comment in line 156 explaining the purpose of these streams.
Also, I renamed out/err names to stdOut/stdErr to make it clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13594#discussion_r1177949748


[prev in list] [next in list] [prev in thread] [next in thread]