[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v15]
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2023-03-31 20:39:17
Message-ID: vxE4zwUGbpQSyiSyDD7lQU7ofMtpqB67A9zPngfpGg0=.e0e4535a-8717-4e63-8088-6e499b20eab3 () github ! com
[Download RAW message or body]

> The fix is to enable virtual threads support for late binding JVMTI agents.
> The fix includes:
> - New function `JvmtiEnvBase::enable_virtual_threads_notify_jvmti()` which does \
> enabling JVMTI VTMS transition notifications in case of agent loaded into running \
> VM. This function executes a VM operation counting VTMS transition bits in all \
> `JavaThread`'s to correctly set the static counter `_VTMS_transition_count` needed \
>                 for VTMS transition protocol.
> - New function `JvmtiEnvBase::disable_virtual_threads_notify_jvmti()` which is \
>                 needed for testing. It is used by the `WhiteBox` API.
> - New WhiteBox function `WB_SetVirtualThreadsNotifyJvmtiMode(JNIEnv* env, jobject \
>                 wb, jboolean enable)` needed for testing of this update.
> - New regression test: `serviceability/jvmti/vthread/ToggleNotifyJvmtiTest`
> 
> Testing:
> - New test: `serviceability/jvmti/vthread/ToggleNotifyJvmtiTest`
> - The originally failed tests are expected to pass now:
> `runtime/vthread/RedefineClass.java`
> `runtime/vthread/TestObjectAllocationSampleEvent.java` 
> - In progress: Run the tiers 1-6 to make sure there are no regression.

Serguei Spitsyn has updated the pull request incrementally with one additional commit \
since the last revision:

  minor simplification in ToggleNotifyJvmtiTest.java

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13133/files
  - new: https://git.openjdk.org/jdk/pull/13133/files/aef87273..c55b6b38

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13133&range=14
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13133&range=13-14

  Stats: 13 lines in 1 file changed: 3 ins; 7 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/13133.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13133/head:pull/13133

PR: https://git.openjdk.org/jdk/pull/13133


[prev in list] [next in list] [prev in thread] [next in thread]