[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/j
From:       Eirik Bjorsnos <duke () openjdk ! org>
Date:       2023-03-27 14:37:25
Message-ID: Vb_NSWF5ml_hQ72mzZqWhnur1pf7HmltP1zQ8vPrvmc=.3aa520f6-3c62-4b18-9e36-6efc0a78e281 () github ! com
[Download RAW message or body]

On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos <duke@openjdk.org> wrote:

> Please review this PR which removes the following outdated guard/check from \
> SunCommandLineLauncher: 
> 
> if ((options.indexOf("-Djava.compiler=") != -1) &&
> (options.toLowerCase().indexOf("-djava.compiler=none") == -1)) {
> throw new IllegalConnectorArgumentsException("Cannot debug with a JIT compiler",
> ARG_OPTIONS);
> }
> 
> 
> 
> Efforts are underway to remove the `java.compiler` system property entirely, \
> besides that this test no longer makes sense since debugging with a JIT has been \
> supported for a while.

This pull request has now been integrated.

Changeset: 46b06023
Author:    Eirik Bjorsnos <eirbjo@gmail.com>
Committer: Alan Bateman <alanb@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/46b0602376893df204bf4d624938bf89abe04d89
                
Stats:     7 lines in 1 file changed: 0 ins; 6 del; 1 mod

8304547: Remove checking of -Djava.compiler in \
src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

Reviewed-by: dholmes, cjplummer, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/13109


[prev in list] [next in list] [prev in thread] [next in thread]