[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/
From:       Eirik Bjorsnos <duke () openjdk ! org>
Date:       2023-03-27 8:47:32
Message-ID: t0eCyRgKzlBpq8KuXt0Rrz4RnIwbWAsF3QeHqWjNANw=.ddf859c5-84c5-4cc5-9b6d-d519631845eb () github ! com
[Download RAW message or body]

On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos <duke@openjdk.org> wrote:

> Please review this PR which removes the following outdated guard/check from \
> SunCommandLineLauncher: 
> 
> if ((options.indexOf("-Djava.compiler=") != -1) &&
> (options.toLowerCase().indexOf("-djava.compiler=none") == -1)) {
> throw new IllegalConnectorArgumentsException("Cannot debug with a JIT compiler",
> ARG_OPTIONS);
> }
> 
> 
> 
> Efforts are underway to remove the `java.compiler` system property entirely, \
> besides that this test no longer makes sense since debugging with a JIT has been \
> supported for a while.

This approved PR is looking for a sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13109#issuecomment-1484745199


[prev in list] [next in list] [prev in thread] [next in thread]