[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v7]
From:       Chen Liang <liach () openjdk ! org>
Date:       2023-03-21 21:39:48
Message-ID: 3PN6riy9fxQHRz1646Xi5fo-V7pTeF_r4Ojgt3yMRtg=.eb0d3145-3d0c-4c3e-b158-d836f7460110 () github ! com
[Download RAW message or body]

> Summaries:
> 1. A few recommendations about updating the constant API is made at \
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html and I \
> may update this patch shall the API changes be integrated before 2. One ASM \
> library-specific test, `LambdaAsm` is removed. Others have their code generation \
> infrastructure upgraded from ASM to Classfile API. 3. Most tests are included in \
> tier1, but some are not: In `:jdk_io`: (tier2, part 2)
> 
> test/jdk/java/io/Serializable/records/SerialPersistentFieldsTest.java
> test/jdk/java/io/Serializable/records/ProhibitedMethods.java
> test/jdk/java/io/Serializable/records/BadCanonicalCtrTest.java
> 
> In `:jdk_instrument`: (tier 3)
> 
> test/jdk/java/lang/instrument/RetransformAgent.java
> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java
> test/jdk/java/lang/instrument/asmlib/Instrumentor.java
> 
> 
> @asotona Would you mind reviewing?

Chen Liang has updated the pull request with a new target base due to a merge or a \
rebase. The pull request now contains 11 commits:

 - Switch to ConstantDescs for <init> <clinit> and void constants
 - Merge AnnotationsTest, remove ModuleTargetAttribute call
 - Merge branch 'invoke-test-classfile' of https://github.com/liachmodded/jdk into \
                invoke-test-classfile
 - Update test/jdk/java/lang/invoke/8022701/MHIllegalAccess.java
   
   Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
 - Merge branch 'master' into invoke-test-classfile
 - Fix LambdaStackTrace after running
 - formatting
 - Fix failed LambdaStackTrace test, use more convenient APIs
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into \
                invoke-test-classfile
 - Shorten lines, move from mask() to ACC_ constants, other misc improvements
 - ... and 1 more: https://git.openjdk.org/jdk/compare/0deb6489...7dc785b3

-------------

Changes: https://git.openjdk.org/jdk/pull/13009/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13009&range=06
  Stats: 1946 lines in 31 files changed: 302 ins; 889 del; 755 mod
  Patch: https://git.openjdk.org/jdk/pull/13009.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13009/head:pull/13009

PR: https://git.openjdk.org/jdk/pull/13009


[prev in list] [next in list] [prev in thread] [next in thread]