[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8300245: Replace NULL with nullptr in share/jfr/ [v4]
From:       Johan =?UTF-8?B?U2rDtmxlbg==?= <jsjolen () openjdk ! org>
Date:       2023-03-21 9:57:52
Message-ID: PJ6IjtdaUB0pQ-5910g2ohdDS_xnGV1w5z5ZMwIKhgY=.d825532d-7f50-43cf-a075-854f8d526bab () github ! com
[Download RAW message or body]

On Tue, 24 Jan 2023 21:10:31 GMT, Johan Sjölen <jsjolen@openjdk.org> wrote:

> > Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory \
> > share/jfr/. Unfortunately the script that does the change isn't perfect, and so \
> > we need to comb through these manually to make sure nothing has gone wrong. I \
> > also review these changes but things slip past my eyes sometimes. 
> > Here are some typical things to look out for:
> > 
> > No changes but copyright header changed (probably because I reverted some changes \
> > but forgot the copyright). Macros having their NULL changed to nullptr, these are \
> > added to the script when I find them. They should be NULL. nullptr in comments \
> > and logs. We try to use lower case "null" in these cases as it reads better. An \
> > exception is made when code expressions are in a comment. 
> > An example of this:
> > 
> > // This function returns null
> > void* ret_null();
> > // This function returns true if *x == nullptr
> > bool is_nullptr(void** x);
> > 
> > Note how nullptr participates in a code expression here, we really are talking \
> > about the specific value nullptr. 
> > Thanks!
> 
> Johan Sjölen has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Fix outdated copyright

Not yet.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12034#issuecomment-1477547098


[prev in list] [next in list] [prev in thread] [next in thread]