[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8302615: make JVMTI thread cpu time functions optional for virtual threads
From:       Alan Bateman <alanb () openjdk ! org>
Date:       2023-02-28 14:31:22
Message-ID: tp-aSuRBEfhDr6HyyCmbCetGjuXC7CdQl5eQw28IzoM=.9c99e973-3772-4077-8deb-09bb072ad535 () github ! com
[Download RAW message or body]

On Thu, 16 Feb 2023 18:05:54 GMT, Serguei Spitsyn <sspitsyn@openjdk.org> wrote:

> This is a minor JVM TI spec update for two timer functions \
> `GetCurrentThreadCpuTime` and `GetThreadCpuTime` to allow implementations to \
> support virtual threads. 
> The CSR is:
> [JDK-8302616](https://bugs.openjdk.org/browse/JDK-8302616): make JVMTI thread cpu \
> time functions optional for virtual threads 
> No testing is needed.

I've just spotted that we missed some text:

GetCurrentThreadCpuTime has "The current thread may not be a virtual thread".

GetThreadCpuTime has "The thread may not be a virtual thread".

The changes that have been integrated allow these functions to support CPU time \
measurement so I think we will need to adjust both of these sentences in a follow up \
issue.

-------------

PR: https://git.openjdk.org/jdk/pull/12604


[prev in list] [next in list] [prev in thread] [next in thread]