[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8299234: JMX Repository.query performance [v6]
From:       Daniel Fuchs <dfuchs () openjdk ! org>
Date:       2023-02-20 17:17:30
Message-ID: lUM3Fu_gUgKUAsVjAx16yqa8FQhUMClqsP57c2ma-9Q=.35f64791-5d0c-499a-8841-35105e3328b9 () github ! com
[Download RAW message or body]

On Fri, 17 Feb 2023 18:25:10 GMT, Alexey Bakhtin <abakhtin@openjdk.org> wrote:

> > Please find a patch to improve JMX Repository.query performance
> > 
> > Using ObjectName.apply() allows significantly decrease memory usage and the \
> > number of GC cycles: Before:
> > 
> > $ java test 1000000 1000000
> > Test PASSED in 8943169791 ns.
> > GC: G1 Young Generation getCollectionCount()=177 getCollectionTime()=118
> > 
> > 
> > After:
> > 
> > $ java test 1000000 1000000
> > Test PASSED in 4808213917 ns.
> > GC: G1 Young Generation getCollectionCount()=88 getCollectionTime()=53
> > 
> > Private ObjectName.matchDomains() method is also updated to minimize unnecessary \
> > memory allocation. 
> > All javax/management jtreg tests passed successfully.
> 
> Alexey Bakhtin has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Add braces

This last version LGTM

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11758


[prev in list] [next in list] [prev in thread] [next in thread]