[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8298979: Remove duplicated serviceability/jvmti/thread/GetAllThreads/allthr01/allthr01.java
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2023-01-31 23:56:51
Message-ID: mVg7xs-Q71vk9xkrpkzGwd6E8wwvYJTMwBVctNzPdEw=.467fd9ae-97fc-4ec1-b21b-b187897b650a () github ! com
[Download RAW message or body]

On Fri, 27 Jan 2023 05:20:28 GMT, Leonid Mesnik <lmesnik@openjdk.org> wrote:

> > PR adds fix "8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing" \
> > to new test and remove duplication. 
> > Test allthr002 ported as
> > serviceability/jvmti/negative/GetAllThreadsNullTest/GetAllThreadsNullTest.java
> 
> Leonid Mesnik has updated the pull request incrementally with two additional \
> commits since the last revision: 
> - cleanup
> - used get_thread_name

The fix looks good to me.
It is nice to remove the duplication.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12240


[prev in list] [next in list] [prev in thread] [next in thread]