[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files
From:       Sergey Bylokhov <serb () openjdk ! org>
Date:       2022-12-05 6:10:04
Message-ID: WPo83xTHqjvUb3Gn342Yy6RUZUjWaFk5kLVV5oJkaoo=.9f954462-1def-40fd-a38a-c74533cee090 () github ! com
[Download RAW message or body]

On Fri, 2 Dec 2022 17:06:23 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an \
> attempt to remove all trailing whitespace from properties files, and enable a \
> jcheck verification that they did not come back, similar to other source code. It \
> turned out that this was not so simple, however, since trailing whitespace in \
> values is actually significant in properties files. 
> To address this, I have opened four bugs on different component teams to either \
> remove the trailing significant whitespace (if it is there erroneously), or convert \
> it to the unicode sequence `\u0020`: \
> [JDK-8298042](https://bugs.openjdk.org/browse/JDK-8298042), \
> [JDK-8298044](https://bugs.openjdk.org/browse/JDK-8298044), \
> [JDK-8298045](https://bugs.openjdk.org/browse/JDK-8298045) and \
> [JDK-8298046](https://bugs.openjdk.org/browse/JDK-8298046). 
> That leaves all the other trailing spaces, in blank lines and in the end of \
> comments. These serve no purpose and should just be removed, and is what this issue \
> concerns. 
> When this and the four "significant whitespace" bugs are all finally integrated, we \
> can finally turn on the verification in jcheck for properties files as well. 
> The changes in this PR is based on \
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729), in #10792. I have \
> restored all the "delete trailing whitespace" changes, except for those with \
> significance. These changes were in turned created by  running `find . -type f \
> -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.

The client changes look fine.

-------------

Marked as reviewed by serb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11491


[prev in list] [next in list] [prev in thread] [next in thread]