[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest
From:       David Holmes <dholmes () openjdk ! org>
Date:       2022-11-30 23:58:26
Message-ID: zkawYaHJZTCyiiLC8DZI2ekKLNrNWPZhmEA0wbUqK2E=.5b342de3-07b5-4f7a-895f-6340a6cad3e2 () github ! com
[Download RAW message or body]

On Wed, 30 Nov 2022 22:17:59 GMT, Daniel D. Daugherty <dcubed@openjdk.org> wrote:

> > > I could not find an @requires incantation for saying do-not-use-slowdebug-bits \
> > > nor one for saying do-not-use-macosx-aarch64. 
> > 
> > Something like:
> > 
> > `@requires vm.debug != slowdebug`
> > `@requires !(os.arch == "aarch64" && os.family == "mac")`
> 
> @dholmes-ora - please let me know if you are okay with these fixes since
> the @requires idea did not work.

@dcubed-ojdk  no objection from me. I was just offering what I hoped was a solution. \
But I see now that `vm.debug` is treated as a boolean: true for `slowdebug` and \
(fast)`debug`; and false otherwise. We would have to add a new property to \
`jtreg-ext/requires/VMProps.java` to allow checking for `slowdebug`.

-------------

PR: https://git.openjdk.org/jdk/pull/11278


[prev in list] [next in list] [prev in thread] [next in thread]