[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v35]
From:       Maurizio Cimadamore <mcimadamore () openjdk ! org>
Date:       2022-11-30 15:30:40
Message-ID: qmTRPgpsuh3MB6RWmVW5G5Y46JWoevBnYC2ljqud5eY=.9571f7b3-113b-420d-90ec-f2f4207d3cc0 () github ! com
[Download RAW message or body]

> This PR contains the API and implementation changes for JEP-434 [1]. A more \
> detailed description of such changes, to avoid repetitions during the review \
> process, is included as a separate comment. 
> [1] - https://openjdk.org/jeps/434

Maurizio Cimadamore has updated the pull request with a new target base due to a \
merge or a rebase. The incremental webrev excludes the unrelated changes brought in \
by the merge/rebase. The pull request contains 67 additional commits since the last \
revision:

 - Merge branch 'master' into PR_20
 - Address review comment
 - Polish javadoc:
   * Make sure that first para of class javadoc is succinct and descriptive
   * Remove references to "access" var handle or "memory segment view" var handle \
                (just use var handle)
   * Minor tweak to layout classes javadoc - use `@see` in value layouts instead of a \
                dedicated para.
   * Other minor typos fixes
 - Address review comments
 - * remove unused Scoped interface
   * re-add trusting of final fields in layout class implementations
   * Fix BulkOps benchmark, which had alignment issues
 - Fix bit vs. byte mismatch in test
 - Fix wrong check in MemorySegment::spliterator/elements
   (The check which ensures that the segment size is multiple of spliterator element \
                size is bogus)
 - Address more review comments
 - Fix bad @throws in MemorySegment::copy methods
 - Address review comments
 - ... and 57 more: https://git.openjdk.org/jdk/compare/d0d99ae1...8668fb39

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10872/files
  - new: https://git.openjdk.org/jdk/pull/10872/files/ce85d182..8668fb39

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10872&range=34
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10872&range=33-34

  Stats: 65983 lines in 1282 files changed: 30320 ins; 21180 del; 14483 mod
  Patch: https://git.openjdk.org/jdk/pull/10872.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10872/head:pull/10872

PR: https://git.openjdk.org/jdk/pull/10872


[prev in list] [next in list] [prev in thread] [next in thread]