[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v3]
From:       Coleen Phillimore <coleenp () openjdk ! org>
Date:       2022-08-31 15:13:12
Message-ID: HqmqlGbOBNPCk0yQIzy-iWuCy2TcGvq0yP58zktnnek=.9a375e61-0b2a-467f-9d44-47c602e69f5b () github ! com
[Download RAW message or body]

On Wed, 31 Aug 2022 05:11:33 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > I think you should add an assert that the `protection_domain.resolve()` never \
> > returns null, with a comment explaining why.
> 
> I agree. In general if code is using WeakHandle's then I would expect to see null \
> checks.

I added the comment.

-------------

PR: https://git.openjdk.org/jdk/pull/10043


[prev in list] [next in list] [prev in thread] [next in thread]