[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8175382: clhsdb pmap should print the end addresses of the load modules
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2022-08-31 9:44:03
Message-ID: TtYyO05ZVoKdrd4QZkTg_nV1S717X7RSpunPsxjaNYk=.8872635d-dbec-44eb-89b7-5cb466da149f () github ! com
[Download RAW message or body]

On Tue, 30 Aug 2022 23:04:18 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> The clhsdb 'pmap' command prints the start addresses and the sizes of the various \
> load modules. It would be more intuitive to have the end address printed as the \
> VM.dynlibs jcmd does.  
> Before:
> 
> 0x00007f8839c38000 5920K /usr/lib64/libc-2.17.so
> 0x00007f883a006000 4072K /usr/lib64/libdl-2.17.so
> 0x00007f883a20a000 4056K /usr/lib64/libpthread-2.17.so
> 0x00007f883a426000 3944K /usr/lib64/libz.so.1.2.7
> 
> After:
> 
> 0x7f0f8e482000-0x7f0f8ea00000 5624K /usr/lib64/libc-2.17.so
> 0x7f0f8e850000-0x7f0f8ec00000 3776K /usr/lib64/libdl-2.17.so
> 0x7f0f8ea54000-0x7f0f8ee00000 3760K /usr/lib64/libpthread-2.17.so
> 0x7f0f8ec70000-0x7f0f8f000000 3648K /usr/lib64/libz.so.1.2.7
> 
> Note that VM.dynlibs doesn't use the 0x prefix. I considered doing the same for \
> pmap, but it did cause one test failure that was searching for the address starting \
> with 0x, so I decided to leave it in. Notice I also dropped the leading 0's to keep \
> things a big more compact (VM.dynlibs does the same).

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10087


[prev in list] [next in list] [prev in thread] [next in thread]