[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Integrated: 8290074: Remove implicit arguments for RegisterMap constructor
From:       Axel Boldt-Christmas <duke () openjdk ! org>
Date:       2022-07-27 12:54:36
Message-ID: FC-tOvJPDa-0xOMgOO7ZwCP4VmDC2gRnF8e6tl0HO5s=.58f2c893-7b70-4ec7-b293-2feefd2c79ee () github ! com
[Download RAW message or body]

On Mon, 11 Jul 2022 14:58:07 GMT, Axel Boldt-Christmas <duke@openjdk.org> wrote:

> Currently the `RegisterMap` constructor uses implicit boolean arguments to \
> configure its function. Implicit boolean arguments makes code harder to understand \
> and reason about at the call site. Using explicit scoped enums instead makes it \
> both clear what is being configured and the type safety makes mistakes less likely. \
>  
> Update `RegisterMap` constructors to use these scoped enum types instead of \
> booleans. ```C++
> enum class UpdateMap { skip, yes };
> enum class ProcessFrames { skip, yes };
> enum class WalkContinuation { skip, yes };
> 
> 
> Testing: tier1-3

This pull request has now been integrated.

Changeset: 2f3e494b
Author:    Axel Boldt-Christmas <axel.boldt-christmas@oracle.com>
Committer: Erik Österlund <eosterlund@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2f3e494b80cce8e357ceac9a897c42d7e8f54af5
                
Stats:     434 lines in 40 files changed: 317 ins; 0 del; 117 mod

8290074: Remove implicit arguments for RegisterMap constructor

Reviewed-by: eosterlund, tschatzl

-------------

PR: https://git.openjdk.org/jdk/pull/9455


[prev in list] [next in list] [prev in thread] [next in thread]