[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [jdk19] RFR: 8287847: Fatal Error when suspending virtual thread after it has terminated [v4]
From:       Chris Plummer <cjplummer () openjdk ! org>
Date:       2022-06-30 17:03:48
Message-ID: vmlm-DMExZ4Lffn_Wcc2E35zHKZhjTVWouRAh-L7kqk=.e152c08e-b3ab-4295-b5ab-3f6285cfbb28 () github ! com
[Download RAW message or body]

> This fixes a bug in the debug agent when there is a request to suspend a virtual \
> thread that has already terminated. The issue was that unless the debug agent was \
> currently under a "suspend all", it would not properly put the virtual thread on \
> the `otherThreads` list, and instead added it to `runningVThreads`. This meant at \
> the end of `insertThread()` the following code tried to do a JVMTI \
> `SetThreadLocalStorage`, which can't be done on a terminated thread. 
> 
> if (list != &otherThreads) {
> setThreadLocalStorage(node->thread, (void*)node);
> }

Chris Plummer has updated the pull request incrementally with one additional commit \
since the last revision:

  No need to initialzie boolean to false.

-------------

Changes:
  - all: https://git.openjdk.org/jdk19/pull/88/files
  - new: https://git.openjdk.org/jdk19/pull/88/files/1884a12e..4caca0eb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk19&pr=88&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk19&pr=88&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk19/pull/88.diff
  Fetch: git fetch https://git.openjdk.org/jdk19 pull/88/head:pull/88

PR: https://git.openjdk.org/jdk19/pull/88


[prev in list] [next in list] [prev in thread] [next in thread]