[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    [jdk19] Integrated: 8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and can_support_v
From:       Alan Bateman <alanb () openjdk ! org>
Date:       2022-06-30 8:53:46
Message-ID: CkXWqxYjRvWvHfvvYOaAReF4040c3msob9aLmhHmGgU=.23fd93f1-04fb-4522-9c55-3fbcae123712 () github ! com
[Download RAW message or body]

On Tue, 28 Jun 2022 09:02:59 GMT, Alan Bateman <alanb@openjdk.org> wrote:

> This is spec only change to the JVM TI spec. The `SuspendAllVirtualThreads` and \
> `ResumeAllVirtualThreads` functions added in Java 19 currently specify that they \
> require one of the capabilities `can_suspend` or `can_support_virtual_threads`. \
> This is not correct as both capabilities are required. 
> The issue is in the XSL used to generate the spec, and specifically the \
> `capabilities` template where it emits different text when the number of required \
> capabilities is not 0 or 1. Additionally, the description of the \
> `can_support_virtual_threads` is overridden in both functions to avoid making it \
> appear that the capability on its own is needed to use these functions.

This pull request has now been integrated.

Changeset: c20b3aa9
Author:    Alan Bateman <alanb@openjdk.org>
URL:       https://git.openjdk.org/jdk19/commit/c20b3aa9c5ada4c87b3421fbc3290f4d6a4706ac
                
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and \
can_support_virtual_threads

Reviewed-by: sspitsyn, dcubed, dholmes, iris

-------------

PR: https://git.openjdk.org/jdk19/pull/82


[prev in list] [next in list] [prev in thread] [next in thread]