[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
From:       David Holmes <dholmes () openjdk ! java ! net>
Date:       2022-04-30 10:57:32
Message-ID: hdAuuc7UUiZ61vymy6rBf0vv2LdbeweXGRTqBUxnRHs=.93290846-a40b-4c87-bc70-7bb9f27fc2da () github ! com
[Download RAW message or body]

On Fri, 29 Apr 2022 10:38:42 GMT, Johannes Bechberger <duke@openjdk.java.net> wrote:

> > src/hotspot/share/prims/forte.cpp line 571:
> > 
> > > 569:   Thread* raw_thread = Thread::current_or_null_safe();
> > > 570: 
> > > 571:   if (trace->env_id == NULL || raw_thread == NULL || \
> > > !raw_thread->is_Java_thread() || ((JavaThread*)raw_thread)->is_exiting()) {
> > 
> > use `rawThread->as_JavaThread()` not a plain cast.
> 
> this method does not exist

Sorry I meant: `JavaThread::cast(rawThread)`

-------------

PR: https://git.openjdk.java.net/jdk/pull/8446


[prev in list] [next in list] [prev in thread] [next in thread]