[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Withdrawn: 8284828: Use `os::ThreadCrashProtection` to protect AsyncGetCallTrace from crashing
From:       Johannes Bechberger <duke () openjdk ! java ! net>
Date:       2022-04-16 7:10:35
Message-ID: jzZ3iSJEnt-ZSzenAmG2AItXwAqvWHRxbMVJjKP58QY=.51b18bad-746a-4cb3-9e17-336d933c26f7 () github ! com
[Download RAW message or body]

On Wed, 13 Apr 2022 14:53:54 GMT, Johannes Bechberger <duke@openjdk.java.net> wrote:

> Move the AsyncGetCallTrace method implementation into a separate method and wrap \
> its call in non-assert compilation mode in `os::ThreadCrashProtection` like it is \
> done in [JFR](https://github.com/openjdk/jdk/blob/965ea8d9cd29aee41ba2b1b0b0c67bb67eca22dd/src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp#L165).
>  This prevents AsyncGetCallTrace from crashing on segmentation faults (but not on \
> `guarantee`s). 
> If a crash is observed, then the `num_frames` field of the trace is set to \
> `ticks_unknown_state` (-7) to signal a state that cannot be properly handled. \
> `ticks_unknown_state` is currently also used for signaling unknown thread states \
> but this should not be a problem, as the semantic is the same. If `num_frames` \
> already has an error code then this error code is not changed. This helps to \
> distinguish between errors in walking threads in Java and non-Java mode, as \
> `num_frames` is set there before the walking to the appropriate error code. 
> _Thanks for @tstuefe for suggesting this._

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8225


[prev in list] [next in list] [prev in thread] [next in thread]