[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8280553: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java can fail if GC
From:       Chris Plummer <cjplummer () openjdk ! java ! net>
Date:       2022-01-29 21:39:09
Message-ID: U60_Wxse4ntJqT8g_o_UOIyWcW_aV0owI4_RK02YqOo=.1d4de85f-7ef8-41c4-800c-ad5546273208 () github ! com
[Download RAW message or body]

On Fri, 28 Jan 2022 07:46:40 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> > This test is failing in the loom repo when using -Xcomp. The reason is because \
> > loom introduced doing a full GC in the codecache sweeper, which causes the large \
> > array that the test allocates to be GC'd before the heap dump is done. The fix is \
> > to make the large array static rather than a local variable. 
> > I'm choosing to fix this in the jdk repo rather than the loom repo since it is a \
> > latent bug that theoretically could occur even without the loom changes, and also \
> > to help reduce the amount of changes to be reviewed when loom is integrated into \
> > jdk.
> 
> Chris Plummer has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Use Reference.reachabilityFence() instead of static field.

Thanks for the reviews Alan and Alex!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7236


[prev in list] [next in list] [prev in thread] [next in thread]