[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail
From:       Alan Bateman <alanb () openjdk ! java ! net>
Date:       2022-01-28 7:49:43
Message-ID: NUcvfCF4WaoSscYX8i8ozREy81SliOJQAc5A6-NbS4A=.0cb12cf5-f147-4008-b5b0-b292e3563c23 () github ! com
[Download RAW message or body]

On Fri, 28 Jan 2022 07:46:01 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> > When using -Xcomp, the liveness of some objects the test allocates is more \
> > precisely known, allowing the objects to be collected before the test expects. \
> > This became an issue in the loom repo because it has changes that result in a \
> > full GC when the codecache is swept. This is fixed by using statics to reference \
> > the objects. Also, if a GC does happen, this seems to get rid of the Survivor \
> > region, so the test was updated to no longer check for it. 
> > I'm choosing to fix this in the jdk repo rather than the loom repo since it is a \
> > latent bug that theoretically could occur even without the loom changes, and also \
> > to help reduce the amount of changes to be reviewed when loom is integrated into \
> > jdk.
> 
> Chris Plummer has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Use Reference.reachabilityFence() instead of static field.

Marked as reviewed by alanb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7257


[prev in list] [next in list] [prev in thread] [next in thread]