[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8244670: convert clhsdb "whatis" command from javascript to java [v3]
From:       Kevin Walls <kevinw () openjdk ! java ! net>
Date:       2021-12-21 9:51:21
Message-ID: Cc7lPPWoj-dTSIb9RyUg9UURhF3_BiSPdOvszSGN0cw=.d9f382a6-b82b-4e8f-a847-6b1aacece195 () github ! com
[Download RAW message or body]

On Mon, 20 Dec 2021 17:46:45 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> > "whatis" is one of the old clhsdb commands that was written in javascript and \
> > lost when Nashorn support was removed. The old "whatis" is the same as the old \
> > "findpc", but also called LoadObject.lookup() on the address and also tried to \
> > determine the C++ Type of the address. However, with the improvements made to \
> > PointerFinder by JDK-8247514, findpc now also includes support for this (plus \
> > other types of address lookups), so these two commands will do the same thing. \
> > I'm still adding "whatis" since some people might still rely on it from when it \
> > worked in JDK 8, and may not know that findpc will do the same.
> 
> Chris Plummer has updated the pull request incrementally with one additional commit \
> since the last revision: 
> fix typo

Marked as reviewed by kevinw (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/6887


[prev in list] [next in list] [prev in thread] [next in thread]