[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8274903: Zero: Support AsyncGetCallTrace [v5]
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2021-11-30 23:26:32
Message-ID: 9Qsyq7smTvNNP3a7WwtYaMDiGesLCvPWF1FTxArevT0=.aa62eb0d-0fbd-4f5b-a15c-5553cf88ecff () github ! com
[Download RAW message or body]

On Tue, 30 Nov 2021 10:47:55 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> > This is a Zero infrastructure improvement that makes Zero VM work with \
> > AsyncGetCallTrace, and by extension, async-profiler. 
> > Zero is quite odd in stack management. The "real" stack actually contains the C++ \
> > Interpreter and the rest of VM code. The Java stack is reported through the usual \
> > "frame" mechanism the rest of VM uses to get the mapping from Template \
> > Interpreter, stub, and compiled code. So, to support Java-centric \
> > AsyncGetCallTrace, we t "only" need Zero to report the proper Java frames from \
> > its ZeroStack from the profiling/signal handlers.  
> > Additional testing:
> > - [x] Linux x86_64 Zero `serviceability/AsyncGetCallTrace` now pass
> > - [x] Linux x86_64 Zero works with `async-profiler`
> 
> Aleksey Shipilev has updated the pull request with a new target base due to a merge \
> or a rebase. The incremental webrev excludes the unrelated changes brought in by \
> the merge/rebase. The pull request contains seven additional commits since the last \
> revision: 
> - Merge branch 'master' into JDK-8274903-zero-asyncgetcalltrace
> - Fix a comment
> - Merge branch 'master' into JDK-8274903-zero-asyncgetcalltrace
> - More reviews
> - Review feedback
> - Merge branch 'master' into JDK-8274903-zero-asyncgetcalltrace
> - Initial work: runs async-profiler successfully

Marked as reviewed by sspitsyn (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5848


[prev in list] [next in list] [prev in thread] [next in thread]