[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2021-11-29 23:25:15
Message-ID: gyv4BsWDDH_x_e6dxd5253nkfeV7ABKdfQdCDpGbgUE=.c34474fd-8699-4b7e-87f9-8d9567fd6548 () github ! com
[Download RAW message or body]

On Mon, 29 Nov 2021 21:38:14 GMT, Liam Miller-Cushon <cushon@openjdk.org> wrote:

> This change fixes `vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001` \
> after [JDK-8271623](https://bugs.openjdk.java.net/browse/JDK-8271623). 
> [JDK-8271623](https://bugs.openjdk.java.net/browse/JDK-8271623) causes javac to \
> omit a synthetic field from inner classes that do not reference their enclosing \
> instance. The test was specifically checking for the presence of the synthetic \
> field. To fix the test, this change adds an explicit reference to the enclosing \
> instance of an inner class.

Hi Liam,
It looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6601


[prev in list] [next in list] [prev in thread] [next in thread]