[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: kludgeMantis is no longer needed?
From: Chris Plummer <chris.plummer () oracle ! com>
Date: 2021-10-28 19:36:49
Message-ID: 5236d6da-6ec0-6292-26ca-0426d3a61d10 () oracle ! com
[Download RAW message or body]
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div class="moz-cite-prefix">I think it is safe to assume that
jvmstat no longer needs to support querying 1.4.2 JVMs. The issue
was fixed in Java 5.<br>
<br>
Chris<br>
<br>
On 10/28/21 12:48 AM, Magnus Ihse Bursie wrote:<br>
</div>
<blockquote type="cite" \
cite="mid:af6e896b-d0fb-ccae-b908-a5e395d1522c@oracle.com">
I noticed the following piece of code in
src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/PerfDataBuffer.java:<br>
<br>
<div style="color: #000000;background-color: #ffffff;font-family: Menlo, \
Monaco, 'Courier New', monospace;font-weight: normal;font-size: 12px;line-height: \
18px;white-space: pre;"><div><span style="color: #000000;"> </span><span \
style="color: #af00db;">if</span><span style="color: #000000;"> (</span><span \
style="color: #001080;">jvm_name</span><span style="color: #000000;">.</span><span \
style="color: #795e26;">stringValue</span><span style="color: \
#000000;">().</span><span style="color: #795e26;">indexOf</span><span style="color: \
#000000;">(</span><span style="color: #a31515;">"HotSpot"</span><span \
style="color: #000000;">) >= </span><span style="color: #098658;">0</span><span \
style="color: #000000;">) {</span></div><div><span style="color: #000000;"> \
</span><span style="color: #af00db;">if</span><span style="color: #000000;"> \
(</span><span style="color: #001080;">jvm_version</span><span style="color: \
#000000;">.</span><span style="color: #795e26;">stringValue</span><span style="color: \
#000000;">().</span><span style="color: #795e26;">startsWith</span><span \
style="color: #000000;">(</span><span style="color: \
#a31515;">"1.4.2"</span><span style="color: #000000;">)) \
{</span></div><div><span style="color: #000000;"> </span><span \
style="color: #795e26;">kludgeMantis</span><span style="color: #000000;">(map, \
args);</span></div><div><span style="color: #000000;"> \
}</span></div><div><span style="color: #000000;"> }</span></div></div> <br>
It looks like there's some room for cleaning out old cruft here...<br>
<br>
/Magnus<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic