[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with
From:       Patricio Chilano Mateo <pchilanomate () openjdk ! java ! net>
Date:       2021-09-30 16:04:38
Message-ID: yEJFDNgEaZyvNr2Nf-i8Oe6tozhkYCAk0HOAQHotYLg=.2aec36bb-457a-4eed-b3d4-251cb652c9ad () github ! com
[Download RAW message or body]

On Wed, 29 Sep 2021 18:35:27 GMT, Chris Plummer <cjplummer@openjdk.org> wrote:

> > Hi,
> > 
> > Please review this simple fix. As pointed out by @dholmes-ora in the bug \
> > comments, the ThreadDeath exception could be delivered and thrown while the \
> > target JavaThread is still executing within the Wicket.unlock call. To fix it I \
> > moved the unlock call inside the try block. I was able to reproduce the issue \
> > locally and verified the test now always passes with the fix. 
> > Thanks,
> > Patricio
> 
> Marked as reviewed by cjplummer (Reviewer).

Thanks for the reviews @plummercj and @sspitsyn!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5742


[prev in list] [next in list] [prev in thread] [next in thread]