[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v5]
From:       Lin Zang <lzang () openjdk ! java ! net>
Date:       2021-08-24 12:36:29
Message-ID: 7iymJyHzXaIWVxKEMfm_u5ECYvgqEQ_NvjLQuVKXRVQ=.e02b1544-3e6a-40dd-b624-edf729cb01f5 () github ! com
[Download RAW message or body]

On Tue, 24 Aug 2021 07:12:51 GMT, Lin Zang <lzang@openjdk.org> wrote:

> > This PR rewrite the implementation of the HeapHprofBinWriter, which could \
> > simplify the logic of current implementation. please see detail description at \
> > https://bugs.openjdk.java.net/browse/JDK-8269685.
> 
> Lin Zang has updated the pull request incrementally with one additional commit \
> since the last revision: 
> code clean up and remove useless methods

Hi Serguei, 
    I update the PR to make the `calculateGlobalJNIHandlesDumpRecordSize()` method \
abstract.   For other empty ones that already there in original implementation, I \
will leave them as they are. do you think it is OK? 

BRs,
Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/4666


[prev in list] [next in list] [prev in thread] [next in thread]