[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8268764: Use Long.hashCode() instead of int-cast where applicable [v4]
From:       Сергей =?UTF-8?B?IA==?= =?UTF-8?B?0KbRi9C/0LDQvdC+0LI=?=
Date:       2021-08-19 11:18:26
Message-ID: 2Y5ulI-nScJrXU-odPSJt0mDFuXaE9cbqwnc0U-tqqI=.c714ad19-2cc1-421d-bf57-12767cd60d25 () github ! com
[Download RAW message or body]

On Thu, 1 Jul 2021 12:19:53 GMT, Сергей Цыпанов \
<github.com+10835776+stsypanov@openjdk.org> wrote:

> > In some JDK classes there's still the following hashCode() implementation:
> > 
> > long objNum;
> > 
> > public int hashCode() {
> > return (int) objNum;
> > }
> > 
> > This outdated expression should be replaced with Long.hashCode(long) as it
> > 
> > - uses all bits of the original value, does not discard any information upfront. \
> > For example, depending on how you are generating the IDs, the upper bits could \
> > change more frequently (or the opposite). 
> > - does not introduce any bias towards values with more ones (zeros), as it would \
> > be the case if the two halves were combined with an OR (AND) operation. 
> > See https://stackoverflow.com/a/4045083
> > 
> > This is related to https://github.com/openjdk/jdk/pull/4309
> 
> Сергей Цыпанов has updated the pull request incrementally with one \
> additional commit since the last revision: 
> 8268764: Update copy-right year

Let's wait, bridgekeeper.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4491


[prev in list] [next in list] [prev in thread] [next in thread]