[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains col
From:       Harold Seigel <hseigel () openjdk ! java ! net>
Date:       2021-08-18 14:28:27
Message-ID: xmKuBFEpRcU9zraSJEmdSorV_XhJo1UhN_e43JL_B5I=.29e2b9ba-9c60-44af-8098-13684816d665 () github ! com
[Download RAW message or body]

On Wed, 18 Aug 2021 13:04:46 GMT, Harold Seigel <hseigel@openjdk.org> wrote:

> > Please review this small fix for JDK-8272124.  The fix puts a limit of 3 when \
> > splitting self cgroup lines by ':' so that Cgroup paths won't get truncated if \
> > they contain embedded ':'s.  For example, an entry of "11:memory:/user.sli:ce" in \
> > a /proc/self/cgroup file will now result in a Cgroup path of "/user.sli:ce" \
> > instead of "/user.sli". 
> > The fix was tested with Mach5 tiers 1 and 2, and Mach5 tiers 3-5 on Linux x64 and \
> > Linux aarch64. 
> > Thanks, Harold
> 
> Harold Seigel has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Fix test typo and error

Thanks Severin and Misha for your reviews and improvements for this fix!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5127


[prev in list] [next in list] [prev in thread] [next in thread]