[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8272120: Avoid looking for standard encodings in "java." modules
From:       Naoto Sato <naoto () openjdk ! java ! net>
Date:       2021-08-11 19:10:26
Message-ID: ItBrtiG4VzdSJQvvY_DeW8gCzBGh1EX6I-sFyqvpxPg=.f4062c6c-1ac0-4f5c-a496-03059a0214f4 () github ! com
[Download RAW message or body]

On Tue, 10 Aug 2021 05:08:54 GMT, Sergey Bylokhov <serb@openjdk.org> wrote:

> This is the continuation of JDK-8233884 and JDK-8271456. This change affects fewer \
> cases so I fix all "java." modules at once. 
> In many places standard charsets are looked up via their names, for example:
> absolutePath.getBytes("UTF-8");
> 
> This could be done more efficiently(up to x20 time faster) with use of \
> java.nio.charset.StandardCharsets: absolutePath.getBytes(StandardCharsets.UTF_8);
> 
> The later variant also makes the code cleaner, as it is known not to throw \
> UnsupportedEncodingException in contrary to the former variant. 
> tested by the tier1/tier2/tier3 tests on Linux/Windows/macOS.

Marked as reviewed by naoto (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5063


[prev in list] [next in list] [prev in thread] [next in thread]