[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8270901: Typo PHASE_CPP in CompilerPhaseType [v2]
From:       Daniel D.Daugherty <dcubed () openjdk ! java ! net>
Date:       2021-07-28 15:48:36
Message-ID: GSIvDJKYWkL2YVkmoIBCvsn2N6Jwt8xYDmopLvCIkoU=.8acf77d3-51c7-4136-830f-6d161afffd70 () github ! com
[Download RAW message or body]

On Wed, 28 Jul 2021 08:38:04 GMT, Yi Yang <yyang@openjdk.org> wrote:

> > For hotspot changes, it would be better to have a second review & wait for 24 \
> > hours before integration.  Thanks.
> 
> > For hotspot changes, it would be better to have a second review & wait for 24 \
> > hours before integration. Thanks.
> 
> Well, it seems a trivial change, maybe one review is okay. For non-trivial changes, \
> we really need more reviews and wait for 24h before merging.

@kelthuzadx - HotSpot changes require two reviews and a 24 hour waiting period.
You may propose in your review request that a change is "trivial" and if your
(R)eviewer agrees, then you may integrate with a single (R)eviewer and you don't
have to wait for 24 hours.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4917


[prev in list] [next in list] [prev in thread] [next in thread]