[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8268857: Merge VM_PrintJNI and VM_PrintThreads and remove the unused field 'is_deadlock' of
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2021-06-28 21:47:09
Message-ID: AWr51Whh-2a-xPaKBOrS9NVSH203FugabPTL65Inxc0=.7cc4dc46-a83b-42b7-87a3-4edf9594fffe () github ! com
[Download RAW message or body]

On Fri, 18 Jun 2021 06:51:53 GMT, Denghui Dong <ddong@openjdk.org> wrote:

> > Hi,
> > 
> > Could I have a review of this change that merges three vm \
> > operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and \
> > signal_thread_entry. 
> > `jstack` is a very common command, even in the production environment.
> > 
> > In addition to reduce the cost of entering safepoint, I think this patch also \
> > could ensure the consistency of the results of VM_PrintThreads and \
> > VM_FindDeadlocks.
> 
> Denghui Dong has updated the pull request incrementally with one additional commit \
> since the last revision: 
> update

Despite the fact it is after the integration it looks good to me. :)
Thanks,
Serguei

-------------

PR: https://git.openjdk.java.net/jdk/pull/4504


[prev in list] [next in list] [prev in thread] [next in thread]