[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8263635: Add --servername option to jhsdb debugd [v5]
From:       Serguei Spitsyn <sspitsyn () openjdk ! java ! net>
Date:       2021-05-25 20:17:35
Message-ID: c7ANVLlAzEmtRoVfmBDijZzkY5jY69p8xQL0L7nwSPM=.53eb2eab-bf87-4a43-bb29-f4ff68b154f0 () github ! com
[Download RAW message or body]

On Fri, 21 May 2021 01:45:59 GMT, Yasumasa Suenaga <ysuenaga@openjdk.org> wrote:

> > `jhsdb debugd` supports server name prefix with \
> > `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as remote \
> > name for SA RMI object. It is "SARemoteDebugger" by default. 
> > As a result, remote name will be constructed as following:
> > 
> > 
> > //host[:port]/<serverNamePrefix>['_'<id>]
> > 
> > 
> > However we have no way to set it excepting system property. jhsdb should provide \
> > the way to set it as a command line option. 
> > serverNamePrefix is used for RMI object name, so "server name" is more suitable \
> > for it. Thus I will add `--servername` to `jhsdb debugd` for this purpose. And \
> > also we should add the way to specify it when we connect to debug server. I will \
> > add it like `--connect id@server:1234/servername`. 
> > I've also filed [CSR for this \
> > PR](https://bugs.openjdk.java.net/browse/JDK-8265897). Please review it. This PR \
> > modifies DisableRegistryTest.java, but it has been addressed in \
> > ProblemList-zgc.txt now. So this PR does not affect ZGC.
> 
> Yasumasa Suenaga has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fix typo

Hi Yasumasa,

It looks good to me.

Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3669


[prev in list] [next in list] [prev in thread] [next in thread]