[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java fails with: com.sun.jdi.InvalidTypeEx
From:       Chris Plummer <cjplummer () openjdk ! java ! net>
Date:       2021-04-30 19:39:54
Message-ID: ynAuU_vRyuA2wliUUTDwgryNB5awsdhb8hiNsoUImgE=.0fc37bee-2c10-42ad-b5ad-8ee35aa74344 () github ! com
[Download RAW message or body]

On Thu, 29 Apr 2021 07:58:26 GMT, Fairoz Matte <fmatte@openjdk.org> wrote:

> > findComponentType() logic is wrong. In findComponentType() method, We always get \
> > vm.classesByName() retruns empty list list = vm.classesByName(parser.typeName());
> > We have "parser.typeName()" retruns " double[][]"
> > vm.classesByName("") is expecting the fully qualified name example \
> > "java.lang.Double" This always returns empty list, resulting into \
> > ClassNotLoadedException as it assumes the Component class has not yet been \
> > loaded, hence the test case fails. 
> > There was a suggested fix from Egor Ushakov from JetBrains, I am proposing the \
> > same to get this fix. I have verified the patch with required testing it works \
> > fine.
> 
> Fairoz Matte has updated the pull request incrementally with two additional commits \
> since the last revision: 
> - Update ArrayReferenceImpl.java
> - Update ArrayTypeImpl.java

Looks good. Please make sure you have run all of the following tests:

test/hotspot/jtreg/vmTestbase/nsk/jdb
test/hotspot/jtreg/serviceability/jdwp
test/hotspot/jtreg/vmTestbase/nsk/jdwp
test/hotspot/jtreg/vmTestbase/nsk/jdi
test/jdk/com/sun/jdi

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3658


[prev in list] [next in list] [prev in thread] [next in thread]